This could probably be fixed by adding a SetupOption class that stores the option name, data type, description, whether or not it requires a reset when changed, etc, and then just creating an array of these upon instantiation of the settings dialog and building the dialog's UI and doing the updates dynamically with a for loop. And adding a new setting requires inserting such code into like 4 or 5 different places. There are a number of places there where it's basically the same code duplicated for a bunch of a different settings.
While we're at it though, the settings dialog could really use some refactoring in the form of abstraction. (ConfigManager::inst()->value( "mixer ", "audiodev " ) != m_audioIfaceNames) || Bool needsRestart = (ConfigManager::inst()-> value( "mixer ", "framesperaudiobuffer " ).toInt() != m_bufferSize) ||
0 kommentar(er)
